Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2349623002: Make hyper-blame ignore automated change of auto to auto* (Closed)

Created:
4 years, 3 months ago by Adam Rice
Modified:
4 years, 3 months ago
Reviewers:
vmpstr, Matt Giuca
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make hyper-blame ignore automated change of auto to auto* A large-scale change has been made to write "auto*" rather than "auto" where the deduced type is a raw pointer. This change is mechanical in nature and so is not useful to show in blame information. Add this set of CLs to .git-blame-ignore-revs. The time period for this set of changes overlaps with the "Re-write many calls to WrapUnique() with MakeUnique()" set of changes, but for clarity they are left as separate sections in the file rather than interleaved. BUG=554600 R=vmpstr@chromium.org Committed: https://crrev.com/f50f9625f30c718b8e1b2756eb4e5be016a81530 Cr-Commit-Position: refs/heads/master@{#419661}

Patch Set 1 #

Patch Set 2 : Add a comment at the top of the block #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -0 lines) Patch
M .git-blame-ignore-revs View 1 1 chunk +125 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Adam Rice
4 years, 3 months ago (2016-09-16 04:32:04 UTC) #1
vmpstr
lgtm, thanks
4 years, 3 months ago (2016-09-16 17:34:15 UTC) #2
Adam Rice
+mgiuca for OWNERS.
4 years, 3 months ago (2016-09-20 01:25:33 UTC) #4
Matt Giuca
lgtm with optional nit: Add a comment to the top of this new block that ...
4 years, 3 months ago (2016-09-20 02:33:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349623002/20001
4 years, 3 months ago (2016-09-20 02:42:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 02:50:07 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 02:52:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f50f9625f30c718b8e1b2756eb4e5be016a81530
Cr-Commit-Position: refs/heads/master@{#419661}

Powered by Google App Engine
This is Rietveld 408576698