Issue 23496069: Escape the builder name when archiving the layout test results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23496069: Escape the builder name when archiving the layout test results. (Closed)

Created:
7 years, 3 months ago by Dirk Pranke

Modified:
7 years, 3 months ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Escape the builder name when archiving the layout test results. Failing to do so leads to incorrect URLs being linked to in the test results :). TBR=ilevy@chromium.org BUG=293928 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223803

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	build/android/buildbot/bb_device_steps.py	View		3 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

7 years, 3 months ago (2013-09-18 05:13:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r223803 (presubmit successful).

Expand Messages | Collapse Messages