Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Unified Diff: content/worker/worker_thread.cc

Issue 23496052: Kill worker process by way of a sync IPC message before it cleans up. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unused header Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/worker/worker_thread.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/worker/worker_thread.cc
diff --git a/content/worker/worker_thread.cc b/content/worker/worker_thread.cc
index 4cabcb4b34c9cee7e1556467b9dd6d56c666c2fb..fd9fce508feac3c4df71605a584b0d77ebbca419 100644
--- a/content/worker/worker_thread.cc
+++ b/content/worker/worker_thread.cc
@@ -56,6 +56,13 @@ WorkerThread::WorkerThread() {
SetRuntimeFeaturesDefaultsAndUpdateFromArgs(command_line);
}
+void WorkerThread::OnProcessFinalRelease() {
+ // The worker process is to be shut down gracefully. Ask the browser
+ // process to shut it down forcefully instead and wait on the message, so that
+ // there are no races between threads when the process is shutting down.
+ Send(new WorkerProcessHostMsg_ForceKillWorker());
michaeln 2013/09/16 22:00:41 Does it not work to have this line as the first an
Mustafa Acer 2013/09/16 22:08:44 It doesn't work.
+}
+
WorkerThread::~WorkerThread() {
}
« no previous file with comments | « content/worker/worker_thread.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698