Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: content/worker/worker_thread.cc

Issue 23496052: Kill worker process by way of a sync IPC message before it cleans up. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add process_ checks Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/worker/worker_thread.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/worker/worker_thread.cc
diff --git a/content/worker/worker_thread.cc b/content/worker/worker_thread.cc
index 4cabcb4b34c9cee7e1556467b9dd6d56c666c2fb..de67978197e7ff50296a3e89c3de922d0288b0cf 100644
--- a/content/worker/worker_thread.cc
+++ b/content/worker/worker_thread.cc
@@ -13,6 +13,7 @@
#include "content/child/indexed_db/indexed_db_message_filter.h"
#include "content/child/runtime_features.h"
#include "content/child/web_database_observer_impl.h"
+#include "content/common/child_process_messages.h"
#include "content/common/worker_messages.h"
#include "content/public/common/content_switches.h"
#include "content/worker/websharedworker_stub.h"
@@ -56,6 +57,13 @@ WorkerThread::WorkerThread() {
SetRuntimeFeaturesDefaultsAndUpdateFromArgs(command_line);
}
+void WorkerThread::OnShutdown() {
+ // The worker process is to be shut down gracefully. Ask the browser
+ // process to shut it down forcefully instead and wait on the message, so that
+ // there are no races between threads when the process is shutting down.
+ Send(new WorkerProcessHostMsg_ForceKillWorker());
+}
+
WorkerThread::~WorkerThread() {
}
@@ -90,6 +98,15 @@ bool WorkerThread::OnControlMessageReceived(const IPC::Message& msg) {
return handled;
}
+bool WorkerThread::OnMessageReceived(const IPC::Message& msg) {
+ bool handled = true;
+ IPC_BEGIN_MESSAGE_MAP(WorkerThread, msg)
+ IPC_MESSAGE_HANDLER(ChildProcessMsg_Shutdown, OnShutdown)
+ IPC_MESSAGE_UNHANDLED(handled = ChildThread::OnMessageReceived(msg))
+ IPC_END_MESSAGE_MAP()
+ return handled;
+}
+
void WorkerThread::OnCreateWorker(
const WorkerProcessMsg_CreateWorker_Params& params) {
WorkerAppCacheInitInfo appcache_init_info(
« no previous file with comments | « content/worker/worker_thread.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698