content/renderer/renderer_webkitplatformsupport_impl.h - Issue 23496051: Make VibrationMessageFilter available to other platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_webkitplatformsupport_impl.h

Issue 23496051: Make VibrationMessageFilter available to other platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch rebased after r231091 Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/port/browser/vibration_provider.h ('K') | « content/public/browser/content_browser_client.cc ('k') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/renderer_webkitplatformsupport_impl.h

diff --git a/content/renderer/renderer_webkitplatformsupport_impl.h b/content/renderer/renderer_webkitplatformsupport_impl.h

index 1a55021faff1b5408fa279fb846796a043a80c08..5cc159537b6b291a45312924321632056b32b6ed 100644

--- a/content/renderer/renderer_webkitplatformsupport_impl.h

+++ b/content/renderer/renderer_webkitplatformsupport_impl.h

@@ -145,10 +145,8 @@ class CONTENT_EXPORT RendererWebKitPlatformSupportImpl

WebKit::WebStorageQuotaType,

WebKit::WebStorageQuotaCallbacks*) OVERRIDE;

-#if defined(OS_ANDROID)

- virtual void vibrate(unsigned int milliseconds);

- virtual void cancelVibration();

-#endif // defined(OS_ANDROID)

+ virtual void vibrate(unsigned int milliseconds) OVERRIDE;

Michael van Ouwerkerk 2013/11/08 14:41:07 Don't add OVERRIDE here. It is generally not used

ostap 2013/11/08 20:33:41 Done.

+ virtual void cancelVibration() OVERRIDE;

Michael van Ouwerkerk 2013/11/08 14:41:07 Also don't add OVERRIDE here.

ostap 2013/11/08 20:33:41 Done.

// Disables the WebSandboxSupport implementation for testing.

// Tests that do not set up a full sandbox environment should call