Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/ProjectImpl.java

Issue 23496048: Add additional hints to the analyzer to catch the 'x is double' dart2js bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase to latest & merge Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/ProjectImpl.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/ProjectImpl.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/ProjectImpl.java
index b9c1751337ab3b62af7568b56cf3e208c327a7ea..6afe721825457a7f37a625e1c0734559e38b6c52 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/ProjectImpl.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/ProjectImpl.java
@@ -426,6 +426,14 @@ public class ProjectImpl extends ContextManagerImpl implements Project {
}
@Override
+ public void setDart2JSHintOption(boolean enableDart2JSHints) {
+ for (AnalysisContext context : getAnalysisContexts()) {
+ AnalysisOptionsImpl options = (AnalysisOptionsImpl) context.getAnalysisOptions();
+ options.setDart2jsHint(enableDart2JSHints);
+ }
+ }
+
+ @Override
public void setHintOption(boolean enableHint) {
for (AnalysisContext context : getAnalysisContexts()) {
AnalysisOptionsImpl options = (AnalysisOptionsImpl) context.getAnalysisOptions();
@@ -605,7 +613,7 @@ public class ProjectImpl extends ContextManagerImpl implements Project {
* @param context the context to be initialized (not {@code null})
* @param container the container with sources to be analyzed
* @param sdk the Dart SDK to use when initializing the context (not {@code null})
- * @param hasPubspec {@code true} if the contaner has a pubspec file
+ * @param hasPubspec {@code true} if the container has a pubspec file
* @return the context (not {@code null})
*/
private AnalysisContext initContext(AnalysisContext context, IContainer container, DartSdk sdk,
@@ -625,6 +633,7 @@ public class ProjectImpl extends ContextManagerImpl implements Project {
AnalysisOptionsImpl options = new AnalysisOptionsImpl();
options.setHint(DartCore.getPlugin().isHintsEnabled());
+ options.setDart2jsHint(DartCore.getPlugin().isHintsDart2JSEnabled());
context.setSourceFactory(sourceFactory);
context.setAnalysisOptions(options);

Powered by Google App Engine
This is Rietveld 408576698