Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/hint/HintGenerator.java

Issue 23496048: Add additional hints to the analyzer to catch the 'x is double' dart2js bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase to latest & merge Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/hint/HintGenerator.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/hint/HintGenerator.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/hint/HintGenerator.java
index 47c57873fc4bdcac7631d0381ff4a1f9d53071d0..11ed77ecd5c71cab48e06ae544a036057a31bd58 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/hint/HintGenerator.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/hint/HintGenerator.java
@@ -39,9 +39,8 @@ public class HintGenerator {
AnalysisErrorListener errorListener;
private ImportsVerifier importsVerifier;
- private DeadCodeVerifier deadCodeVerifier;
-//private PubVerifier pubVerifier;
+ private final boolean enableDart2JSHints;
public HintGenerator(CompilationUnit[] compilationUnits, AnalysisContext context,
AnalysisErrorListener errorListener) {
@@ -50,6 +49,7 @@ public class HintGenerator {
this.errorListener = errorListener;
LibraryElement library = compilationUnits[0].getElement().getLibrary();
importsVerifier = new ImportsVerifier(library);
+ enableDart2JSHints = context.getAnalysisOptions().getDart2jsHint();
}
public void generateForLibrary() throws AnalysisException {
@@ -75,10 +75,15 @@ public class HintGenerator {
importsVerifier.visitCompilationUnit(unit);
- deadCodeVerifier = new DeadCodeVerifier(errorReporter);
- deadCodeVerifier.visitCompilationUnit(unit);
+ // dead code analysis
+ new DeadCodeVerifier(errorReporter).visitCompilationUnit(unit);
-// pubVerifier = new PubVerifier(context, errorReporter);
-// pubVerifier.visitCompilationUnit(unit);
+ // dart2js analysis
+ if (enableDart2JSHints) {
+ new Dart2JSVerifier(errorReporter).visitCompilationUnit(unit);
+ }
+
+ // pub analysis
+// new PubVerifier(context, errorReporter).visitCompilationUnit(unit);
}
}

Powered by Google App Engine
This is Rietveld 408576698