Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisOptionsImpl.java

Issue 23496048: Add additional hints to the analyzer to catch the 'x is double' dart2js bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase to latest & merge Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisOptionsImpl.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisOptionsImpl.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisOptionsImpl.java
index fa2f298a63332d69bf2aaf5a792bfcaab12ef362..382336006a9a2dd41ab9a217277a14ce4b3bbb48 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisOptionsImpl.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisOptionsImpl.java
@@ -33,12 +33,22 @@ public class AnalysisOptionsImpl implements AnalysisOptions {
private boolean hint = true;
/**
+ * A flag indicating whether analysis is to generate dart2js related hint results.
+ */
+ private boolean dart2jsHint = true;
+
+ /**
* Initialize a newly created set of analysis options to have their default values.
*/
public AnalysisOptionsImpl() {
}
@Override
+ public boolean getDart2jsHint() {
+ return dart2jsHint;
+ }
+
+ @Override
public boolean getHint() {
return hint;
}
@@ -55,6 +65,15 @@ public class AnalysisOptionsImpl implements AnalysisOptions {
}
/**
+ * Set whether analysis is to generate dart2js related hint results.
+ *
+ * @param hint {@code true} if analysis is to generate dart2js related hint results
+ */
+ public void setDart2jsHint(boolean dart2jsHints) {
+ this.dart2jsHint = dart2jsHints;
+ }
+
+ /**
* Set whether analysis is to generate hint results (e.g. type inference based information and pub
* best practices).
*

Powered by Google App Engine
This is Rietveld 408576698