V4LDBM: Get response from GetHashManager, detect severest result

components/safe_browsing_db/v4_local_database_manager_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
 #include "components/safe_browsing_db/v4_database.h"
@@ skipping 118 matching lines @@
   ReplaceV4Database(store_and_hash_prefixes);
 
   // The same URL returns |false| in the previous test because
   // v4_local_database_manager_ is enabled.
   ForceDisableLocalDatabaseManager();
 
   EXPECT_TRUE(v4_local_database_manager_->CheckBrowseUrl(
       GURL("http://example.com/a/"), nullptr));
 }
 
+TEST_F(V4LocalDatabaseManagerTest, TestGetSeverestThreatTypeAndMetadata) {
+  FullHashInfo fhi_malware(FullHash("Malware"), GetUrlMalwareId(),
+                           base::Time::Now());
+  fhi_malware.metadata.population_id = "malware_popid";
+
+  FullHashInfo fhi_api(FullHash("api"), GetChromeUrlApiId(), base::Time::Now());
+  fhi_api.metadata.population_id = "api_popid";
+
+  std::vector<FullHashInfo> fhis({fhi_malware, fhi_api});
+
+  SBThreatType result_threat_type;
+  ThreatMetadata metadata;
+
+  V4LocalDatabaseManager::GetSeverestThreatTypeAndMetadata(&result_threat_type,
+                                                           &metadata, fhis);
+  EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE, result_threat_type);
+  EXPECT_EQ("malware_popid", metadata.population_id);
+
+  // Reversing the list has no effect.
+  std::reverse(std::begin(fhis), std::end(fhis));

[Scott Hess - ex-Googler, 2016/09/20 21:55:56]

I may not understand something, here, but a one-element list is the same
forwards and backwards!

[vakh (use Gerrit instead), 2016/09/21 17:43:40]

The list has two elements: fhi_malware, fhi_api

[Scott Hess - ex-Googler, 2016/09/21 19:15:51]

I swear, I checked a couple times before making the comment, and it only had one
element.  But looking here, it clearly has more than one.  *Shrug*.  Guide me
gently back to my desk if you find me wandering around.

+  V4LocalDatabaseManager::GetSeverestThreatTypeAndMetadata(&result_threat_type,
+                                                           &metadata, fhis);
+  EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE, result_threat_type);
+  EXPECT_EQ("malware_popid", metadata.population_id);
+}
+
 }  // namespace safe_browsing