Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 23496030: [Coverity] Extension pointer can be null in the if clause, so we should rely on extension_id (Closed)

Created:
7 years, 3 months ago by Finnur
Modified:
7 years, 3 months ago
Reviewers:
Gaurav, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Extension pointer can be null in the if clause, so we should rely on extension_id instead of extension->id(). BUG=None CID=109059 TBR=yoz Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221692

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Finnur
7 years, 3 months ago (2013-09-02 18:09:57 UTC) #1
Finnur
Friendly ping.
7 years, 3 months ago (2013-09-03 14:45:56 UTC) #2
Gaurav
On 2013/09/03 14:45:56, Finnur wrote: > Friendly ping. lgtm
7 years, 3 months ago (2013-09-05 18:16:21 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 3 months ago (2013-09-06 08:49:09 UTC) #4
Finnur
On 2013/09/06 08:49:09, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
7 years, 3 months ago (2013-09-06 08:58:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/23496030/1
7 years, 3 months ago (2013-09-06 08:59:34 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 12:34:08 UTC) #7
Message was sent while issue was closed.
Change committed as 221692

Powered by Google App Engine
This is Rietveld 408576698