src/hydrogen-canonicalize.cc - Issue 23496017: Shr should save its Use truncating flag before Canonicalize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-canonicalize.cc

Issue 23496017: Shr should save its Use truncating flag before Canonicalize (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-canonicalize.cc

diff --git a/src/hydrogen-canonicalize.cc b/src/hydrogen-canonicalize.cc

index 4d96415e6a8142b40a2e74ed6c17011bb18bf071..d9c53922685cc0a69c4846a006fa091493dc2e64 100644

--- a/src/hydrogen-canonicalize.cc

+++ b/src/hydrogen-canonicalize.cc

@@ -38,7 +38,7 @@ void HCanonicalizePhase::Run() {

for (int i = 0; i < blocks->length(); ++i) {

for (HInstructionIterator it(blocks->at(i)); !it.Done(); it.Advance()) {

HInstruction* instr = it.Current();

- if (instr->IsArithmeticBinaryOperation()) {

+ if (instr->IsArithmeticBinaryOperation() || instr->IsShr()) {

if (instr->representation().IsInteger32()) {

if (instr->HasAtLeastOneUseWithFlagAndNoneWithout(

HInstruction::kTruncatingToInt32)) {

« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »