Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 23496017: Shr should save its Use truncating flag before Canonicalize (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | test/mjsunit/shr-truncating-nouint32.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 724 matching lines...) Expand 10 before | Expand all | Expand 10 after
735 right = UseFixed(right_value, rcx); 735 right = UseFixed(right_value, rcx);
736 } 736 }
737 737
738 // Shift operations can only deoptimize if we do a logical shift by 0 and 738 // Shift operations can only deoptimize if we do a logical shift by 0 and
739 // the result cannot be truncated to int32. 739 // the result cannot be truncated to int32.
740 bool does_deopt = false; 740 bool does_deopt = false;
741 if (op == Token::SHR && constant_value == 0) { 741 if (op == Token::SHR && constant_value == 0) {
742 if (FLAG_opt_safe_uint32_operations) { 742 if (FLAG_opt_safe_uint32_operations) {
743 does_deopt = !instr->CheckFlag(HInstruction::kUint32); 743 does_deopt = !instr->CheckFlag(HInstruction::kUint32);
744 } else { 744 } else {
745 does_deopt = !instr->CheckUsesForFlag(HValue::kTruncatingToInt32); 745 does_deopt = !instr->CheckFlag(HInstruction::kAllUsesTruncatingToInt32);
746 } 746 }
747 } 747 }
748 748
749 LInstruction* result = 749 LInstruction* result =
750 DefineSameAsFirst(new(zone()) LShiftI(op, left, right, does_deopt)); 750 DefineSameAsFirst(new(zone()) LShiftI(op, left, right, does_deopt));
751 return does_deopt ? AssignEnvironment(result) : result; 751 return does_deopt ? AssignEnvironment(result) : result;
752 } 752 }
753 753
754 754
755 LInstruction* LChunkBuilder::DoArithmeticD(Token::Value op, 755 LInstruction* LChunkBuilder::DoArithmeticD(Token::Value op,
(...skipping 1770 matching lines...) Expand 10 before | Expand all | Expand 10 after
2526 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2526 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2527 LOperand* object = UseRegister(instr->object()); 2527 LOperand* object = UseRegister(instr->object());
2528 LOperand* index = UseTempRegister(instr->index()); 2528 LOperand* index = UseTempRegister(instr->index());
2529 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2529 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2530 } 2530 }
2531 2531
2532 2532
2533 } } // namespace v8::internal 2533 } } // namespace v8::internal
2534 2534
2535 #endif // V8_TARGET_ARCH_X64 2535 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | test/mjsunit/shr-truncating-nouint32.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698