Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 23496017: Shr should save its Use truncating flag before Canonicalize (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/hydrogen-canonicalize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 720 matching lines...) Expand 10 before | Expand all | Expand 10 after
731 } else { 731 } else {
732 right = UseRegisterAtStart(right_value); 732 right = UseRegisterAtStart(right_value);
733 } 733 }
734 734
735 // Shift operations can only deoptimize if we do a logical shift 735 // Shift operations can only deoptimize if we do a logical shift
736 // by 0 and the result cannot be truncated to int32. 736 // by 0 and the result cannot be truncated to int32.
737 if (op == Token::SHR && constant_value == 0) { 737 if (op == Token::SHR && constant_value == 0) {
738 if (FLAG_opt_safe_uint32_operations) { 738 if (FLAG_opt_safe_uint32_operations) {
739 does_deopt = !instr->CheckFlag(HInstruction::kUint32); 739 does_deopt = !instr->CheckFlag(HInstruction::kUint32);
740 } else { 740 } else {
741 does_deopt = !instr->CheckUsesForFlag(HValue::kTruncatingToInt32); 741 does_deopt = !instr->CheckFlag(HInstruction::kAllUsesTruncatingToInt32);
742 } 742 }
743 } 743 }
744 744
745 LInstruction* result = 745 LInstruction* result =
746 DefineAsRegister(new(zone()) LShiftI(op, left, right, does_deopt)); 746 DefineAsRegister(new(zone()) LShiftI(op, left, right, does_deopt));
747 return does_deopt ? AssignEnvironment(result) : result; 747 return does_deopt ? AssignEnvironment(result) : result;
748 } 748 }
749 749
750 750
751 LInstruction* LChunkBuilder::DoArithmeticD(Token::Value op, 751 LInstruction* LChunkBuilder::DoArithmeticD(Token::Value op,
(...skipping 1831 matching lines...) Expand 10 before | Expand all | Expand 10 after
2583 2583
2584 2584
2585 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2585 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2586 LOperand* object = UseRegister(instr->object()); 2586 LOperand* object = UseRegister(instr->object());
2587 LOperand* index = UseRegister(instr->index()); 2587 LOperand* index = UseRegister(instr->index());
2588 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2588 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2589 } 2589 }
2590 2590
2591 2591
2592 } } // namespace v8::internal 2592 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-canonicalize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698