User interruption should still create results.html for run-webkit-tests.

Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Index: Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
index 5fef70088e0fe95f1629917a32412f5e1d4b2f50..d78e198690723d9eb100741bd21b0e0972a4f48c 100644
--- a/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
@@ -38,6 +38,7 @@ import datetime
 import json
 import logging
 import random
+import signal
 import sys
 import time
 
@@ -249,7 +250,10 @@ class Manager(object):
 
             results_path = self._filesystem.join(self._results_directory, "results.html")
             self._copy_results_html_file(results_path)
-            if self._options.show_results and (exit_code or (self._options.full_results_html and initial_results.total_failures)):
+            if initial_results.interrupted:
+                _INTERRUPTED_EXIT_STATUS = signal.SIGINT + 128
+                exit_code = _INTERRUPTED_EXIT_STATUS
+            elif self._options.show_results and (exit_code or (self._options.full_results_html and initial_results.total_failures)):
                 self._port.show_results_html_file(results_path)
 
         self._printer.print_results(time.time() - start_time, initial_results, summarized_failing_results)

[Dirk Pranke, 2013/08/29 17:04:26]

I think we probably shouldn't print the results if the run was manually
interrupted, but I'm not 100% certain of this.

Context: the basic idea behind the way I implemented the keyboard-interrupt
support was to exit as quickly as possible while still exiting cleanly and to do
what amount of work still seemed to be sensible (w/o blocking). So, I didn't
create the results.html file or print things because it was slow and because it
might not make sense. I think creating the results probably isn't actually that
slow, and I can see the argument that it makes sense in some or maybe even most
cases. However, I doubt printing the results make sense (even if it's not slow).