Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py - Issue 23496003: User interruption should still create results.html for run-webkit-tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

Issue 23496003: User interruption should still create results.html for run-webkit-tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/controllers/manager.py » ('j') | Tools/Scripts/webkitpy/layout_tests/controllers/manager.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py b/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

index 7bdcd984fd9a331a5ee7c19d6224379a917117dc..85dc21cd935a48d1b1e5a3f11c394aebca31fa52 100644

--- a/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

@@ -120,7 +120,8 @@ class LayoutTestRunner(object):

except KeyboardInterrupt:

self._printer.flush()

self._printer.writeln('Interrupted, exiting ...')

- raise

+ # Mark execution got interrupted and return results for tests executed till now.

Dirk Pranke 2013/09/13 05:37:31 I don't think we really need the comment here. The

r.kasibhatla 2013/09/13 13:43:35 Done.

+ run_results.keyboard_interrupted = True

except Exception, e:

_log.debug('%s("%s") raised, exiting' % (e.__class__.__name__, str(e)))

raise

« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/controllers/manager.py » ('j') | Tools/Scripts/webkitpy/layout_tests/controllers/manager.py » ('J')