Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py - Issue 23496003: User interruption should still create results.html for run-webkit-tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 23496003: User interruption should still create results.html for run-webkit-tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed failing webkitpy tests and skipping printing of bot results in case of user interruption. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Tools/Scripts/webkitpy/layout_tests/controllers/manager.py ('K') | « Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py ('k') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

index d5a059be956e4d231714091670361e37ebd449af..06266d3d92119b7e15c478e185dfe618e0235b4a 100644

--- a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

+++ b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -78,11 +78,12 @@ def main(argv, stdout, stderr):

try:

run_details = run(port, options, args, stderr)

- if run_details.exit_code != -1:

+ if run_details.exit_code != -1 and not run_details.initial_results.keyboard_interrupted:

bot_printer = buildbot_results.BuildBotPrinter(stdout, options.debug_rwt_logging)

bot_printer.print_results(run_details)

return run_details.exit_code

+ # We need to still handle KeyboardInterrupt, atleast for webkitpy unittest cases.

except KeyboardInterrupt:

return INTERRUPTED_EXIT_STATUS

except BaseException as e: