Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py - Issue 23496003: User interruption should still create results.html for run-webkit-tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 23496003: User interruption should still create results.html for run-webkit-tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rework-patchset3 Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Tools/Scripts/webkitpy/layout_tests/controllers/manager.py ('K') | « Tools/Scripts/webkitpy/layout_tests/controllers/manager.py ('k') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

index d5a059be956e4d231714091670361e37ebd449af..6a9f57aa0a69830f007f57258c0a4be873b9278a 100644

--- a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

+++ b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -31,7 +31,6 @@

import logging

import optparse

import os

-import signal

import sys

import traceback

@@ -45,9 +44,6 @@ from webkitpy.layout_tests.views import printing

_log = logging.getLogger(__name__)

-# This mirrors what the shell normally does.

-INTERRUPTED_EXIT_STATUS = signal.SIGINT + 128

# This is a randomly chosen exit code that can be tested against to

# indicate that an unexpected exception occurred.

EXCEPTIONAL_EXIT_STATUS = 254

@@ -83,8 +79,6 @@ def main(argv, stdout, stderr):

bot_printer.print_results(run_details)

return run_details.exit_code

- except KeyboardInterrupt:

- return INTERRUPTED_EXIT_STATUS

except BaseException as e:

if isinstance(e, Exception):

print >> stderr, '\n%s raised: %s' % (e.__class__.__name__, str(e))