User interruption should still create results.html for run-webkit-tests.

Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Szeged
 # Copyright (C) 2011 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 13 matching lines @@
 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import logging
 import optparse
 import os
-import signal
 import sys
 import traceback
 
 from webkitpy.common.host import Host
 from webkitpy.layout_tests.controllers.manager import Manager
+from webkitpy.layout_tests.models.test_run_results import TestRunResults

[Dirk Pranke, 2013/09/13 05:37:31]

Change this to 

from webkitpy.layout_tests.models.test_run_results import
INTERRUPTED_EXIT_STATUS

then that becomes a name in the module-level scope here as well, making it the
same as if you weren't deleting lines 48-50 in the old patch.

[r.kasibhatla, 2013/09/13 13:43:35]

Done.

 from webkitpy.layout_tests.port import configuration_options, platform_options
 from webkitpy.layout_tests.views import buildbot_results
 from webkitpy.layout_tests.views import printing
 
 
 _log = logging.getLogger(__name__)
 
 
-# This mirrors what the shell normally does.
-INTERRUPTED_EXIT_STATUS = signal.SIGINT + 128
-
 # This is a randomly chosen exit code that can be tested against to
 # indicate that an unexpected exception occurred.
 EXCEPTIONAL_EXIT_STATUS = 254
 
 
 def main(argv, stdout, stderr):
     options, args = parse_args(argv)
 
     if options.platform and 'test' in options.platform:
         # It's a bit lame to import mocks into real code, but this allows the user
@@ skipping 10 matching lines @@
 
     try:
         port = host.port_factory.get(options.platform, options)
     except NotImplementedError, e:
         # FIXME: is this the best way to handle unsupported port names?
         print >> stderr, str(e)
         return EXCEPTIONAL_EXIT_STATUS
 
     try:
         run_details = run(port, options, args, stderr)
-        if run_details.exit_code != -1:
+        if run_details.exit_code != -1 and not run_details.initial_results.keyboard_interrupted:
             bot_printer = buildbot_results.BuildBotPrinter(stdout, options.debug_rwt_logging)
             bot_printer.print_results(run_details)
 
         return run_details.exit_code
+    # We need to still handle KeyboardInterrupt, atleast for webkitpy unittest cases.
     except KeyboardInterrupt:
-        return INTERRUPTED_EXIT_STATUS
+        return TestRunResults.INTERRUPTED_EXIT_STATUS

[Dirk Pranke, 2013/09/13 05:37:31]

Now you can use the old unqualified name here.

[r.kasibhatla, 2013/09/13 13:43:35]

Done.

     except BaseException as e:
         if isinstance(e, Exception):
             print >> stderr, '\n%s raised: %s' % (e.__class__.__name__, str(e))
             traceback.print_exc(file=stderr)
         return EXCEPTIONAL_EXIT_STATUS
 
 
 def parse_args(args):
     option_group_definitions = []
 
@@ skipping 249 matching lines @@
         printer.print_config(port.results_directory())
 
         run_details = manager.run(args)
         _log.debug("Testing completed, Exit status: %d" % run_details.exit_code)
         return run_details
     finally:
         printer.cleanup()
 
 if __name__ == '__main__':
     sys.exit(main(sys.argv[1:], sys.stdout, sys.stderr))