Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2349593004: Revert of [Tracing] Remove unnecessary memory allocation in runtime call stats. (Closed)

Created:
4 years, 3 months ago by vogelheim
Modified:
4 years, 3 months ago
Reviewers:
lpy, fmeawad, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Tracing] Remove unnecessary memory allocation in runtime call stats. (patchset #1 id:1 of https://codereview.chromium.org/2342643004/ ) Reason for revert: Revert because this breaks V8's roll into Chromium. ASAN complains about memory accesses in a particular unit test. Borked roll CL: https://codereview.chromium.org/2348833002/ Reproduce breakage with: 1, args.gn: v8_deprecation_warnings = true use_goma = true is_asan = true 2, ninja -C out/... content_browsertests 3, out/.../content_browsertests --gtest_filter=V8SamplingProfilerTest.* Original issue's description: > [Tracing] Remove unnecessary memory allocation in runtime call stats. > > Previously we didn't implement TRACE_STR_COPY when we write trace events to > file, which causes us to allocate a growing independent memory chunk for dumped > runtime call stats table. Since we now have a fully functional TRACE_STR_COPY, > this memory allocation can be avoided, this patch removes it. > > BUG=v8:5089 > > Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039 > Cr-Commit-Position: refs/heads/master@{#39462} TBR=cbruni@chromium.org,fmeawad@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Committed: https://crrev.com/eb7ba29012958b2907d2cf98740b5ff078fa6823 Cr-Commit-Position: refs/heads/master@{#39475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/counters.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/counters.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
vogelheim
Created Revert of [Tracing] Remove unnecessary memory allocation in runtime call stats.
4 years, 3 months ago (2016-09-16 14:20:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349593004/1
4 years, 3 months ago (2016-09-16 14:20:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 14:20:43 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 14:21:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb7ba29012958b2907d2cf98740b5ff078fa6823
Cr-Commit-Position: refs/heads/master@{#39475}

Powered by Google App Engine
This is Rietveld 408576698