Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2349583002: Adding UiAccess enabled binary to the signing list (Closed)

Created:
4 years, 3 months ago by joedow
Modified:
4 years, 3 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding UiAccess enabled binary to the signing list This is needed to allow the UiAccess enabled binary to work. Otherwise the binary will crash on launch which is an undesirable behavior. BUG=617185 Committed: https://crrev.com/6bdf6f38d40d69ea093f7577a654d0b87d81c09c Cr-Commit-Position: refs/heads/master@{#419211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/host/installer/win/parameters.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
joedow
PTAL!
4 years, 3 months ago (2016-09-16 00:28:34 UTC) #3
joedow
Adding Jamie since Sergey is OOO. Can you take a look Jamie?
4 years, 3 months ago (2016-09-16 14:25:31 UTC) #8
Jamie
lgtm
4 years, 3 months ago (2016-09-16 17:35:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349583002/1
4 years, 3 months ago (2016-09-16 17:45:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 17:52:01 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 17:53:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bdf6f38d40d69ea093f7577a654d0b87d81c09c
Cr-Commit-Position: refs/heads/master@{#419211}

Powered by Google App Engine
This is Rietveld 408576698