Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2349563002: [gin] Plumb TraceLogStateObserver into v8. (Closed)

Created:
4 years, 3 months ago by alph
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb TraceLogStateObserver into v8. BUG=406277 Committed: https://crrev.com/290f630de7dd9909f71e731fabafc3fe7c35e49a Cr-Commit-Position: refs/heads/master@{#419903}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixing nit. #

Patch Set 3 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M gin/public/v8_platform.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gin/v8_platform.cc View 1 2 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
alph
PTAL. This is chromium part of plumbing trace observer to v8. v8 part is at ...
4 years, 3 months ago (2016-09-15 23:36:47 UTC) #2
fmeawad
lgtm
4 years, 3 months ago (2016-09-15 23:43:16 UTC) #3
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/2349563002/diff/1/gin/v8_platform.cc File gin/v8_platform.cc (right): https://codereview.chromium.org/2349563002/diff/1/gin/v8_platform.cc#newcode169 gin/v8_platform.cc:169: }; disallow copy/ assign
4 years, 3 months ago (2016-09-19 14:24:18 UTC) #5
alph
https://codereview.chromium.org/2349563002/diff/1/gin/v8_platform.cc File gin/v8_platform.cc (right): https://codereview.chromium.org/2349563002/diff/1/gin/v8_platform.cc#newcode169 gin/v8_platform.cc:169: }; On 2016/09/19 14:24:18, jochen wrote: > disallow copy/ ...
4 years, 3 months ago (2016-09-20 21:19:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349563002/20001
4 years, 3 months ago (2016-09-20 21:20:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/271827) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-20 21:28:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349563002/40001
4 years, 3 months ago (2016-09-20 21:35:05 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-21 00:00:59 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 00:04:03 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/290f630de7dd9909f71e731fabafc3fe7c35e49a
Cr-Commit-Position: refs/heads/master@{#419903}

Powered by Google App Engine
This is Rietveld 408576698