Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: cc/tiles/gpu_image_decode_controller.cc

Issue 2349553002: Keep allocation size available in minidumps. (Closed)
Patch Set: Builds. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/gpu_image_decode_controller.cc
diff --git a/cc/tiles/gpu_image_decode_controller.cc b/cc/tiles/gpu_image_decode_controller.cc
index 405879e9f65abf76460441306366a9df3a84bd41..fd4663334c5c2ff4927fdb9ac062f462bb9baeac 100644
--- a/cc/tiles/gpu_image_decode_controller.cc
+++ b/cc/tiles/gpu_image_decode_controller.cc
@@ -6,6 +6,7 @@
#include <inttypes.h>
+#include "base/debug/alias.h"
#include "base/memory/discardable_memory_allocator.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
@@ -945,9 +946,10 @@ void GpuImageDecodeController::DecodeImageIfNecessary(
{
base::AutoUnlock unlock(lock_);
+ auto image_data_size = image_data->size;
vmpstr 2016/09/16 00:07:41 nit: size_t instead of auto. I'm guessing you don
cblume 2016/09/16 00:13:58 I plan to remove this code in short order. I only
+ base::debug::Alias(&image_data_size);
backing_memory = base::DiscardableMemoryAllocator::GetInstance()
->AllocateLockedDiscardableMemory(image_data->size);
- CHECK(backing_memory);
switch (image_data->mode) {
case DecodedDataMode::CPU: {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698