Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2349543002: In update_w3c_test_expectations use ExpectationLine.tokenize_line and refactor. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In update_w3c_test_expectations use ExpectationLine.tokenize_line and refactor. In this CL: - Make test methods in update_w3c_test_expectations have more realistic examples. - Change some lines in write_to_test_expectations to make that method shorter. This is a refactoring CL (no behavior changes). BUG=647395 Committed: https://crrev.com/d8df377160ed2d41799df0ddfa30f44065059ee7 Cr-Commit-Position: refs/heads/master@{#419215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -35 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 2 chunks +17 lines, -23 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 1 chunk +40 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
4 years, 3 months ago (2016-09-15 23:07:58 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-16 00:33:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349543002/1
4 years, 3 months ago (2016-09-16 16:57:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 18:11:25 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 18:13:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8df377160ed2d41799df0ddfa30f44065059ee7
Cr-Commit-Position: refs/heads/master@{#419215}

Powered by Google App Engine
This is Rietveld 408576698