Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2349533002: [DevTools] Migrate RevisionHistoryView to TreeOutlineInShadow. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
caseq, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate RevisionHistoryView to TreeOutlineInShadow. This is a step towards turning all tree outlines into independent web components, removing global styles related to it and allowing more components to encapsulate their inner details. BUG=none Committed: https://crrev.com/50ef51e05d003c9d9f31bec84200eb09507b30fd Cr-Commit-Position: refs/heads/master@{#419089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -34 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/revisionHistory.css View 2 chunks +4 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-09-15 22:44:06 UTC) #2
dgozman
+caseq
4 years, 3 months ago (2016-09-16 00:05:50 UTC) #4
caseq
lgtm
4 years, 3 months ago (2016-09-16 00:22:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349533002/1
4 years, 3 months ago (2016-09-16 00:32:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 03:15:55 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 03:20:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50ef51e05d003c9d9f31bec84200eb09507b30fd
Cr-Commit-Position: refs/heads/master@{#419089}

Powered by Google App Engine
This is Rietveld 408576698