Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 234953002: Fail the compilation if the cached data is invalid. (Closed)

Created:
6 years, 8 months ago by marja
Modified:
6 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fail the compilation if the cached data is invalid. R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20703

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -51 lines) Patch
M src/api.cc View 1 2 3 1 chunk +21 lines, -17 lines 0 comments Download
M src/messages.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/parser.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/parser.cc View 1 2 5 chunks +11 lines, -18 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 3 chunks +37 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
lgtm
6 years, 8 months ago (2014-04-11 11:19:28 UTC) #1
marja
6 years, 8 months ago (2014-04-14 07:35:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #4 manually as r20703 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698