Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2349523002: Add support for edit commands in OOPIFs. (Closed)

Created:
4 years, 3 months ago by alexmos
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Add support for edit commands in OOPIFs. Previously, edit commands from the browser were sent via InputMsg_SetEditCommandsForNextKeyEvent to focused RenderWidgets, but for OOPIFs the IPC was dropped since it was only handled in RenderViews. To fix this, this CL moves the IPC handling and associated edit command bookkeeping to RenderWidget. BUG=640706 Review-Url: https://codereview.chromium.org/2287803002 Cr-Commit-Position: refs/heads/master@{#418126} (cherry picked from commit 5656749d827dc6af03caed97958bd1ff035d1e61) Committed: https://chromium.googlesource.com/chromium/src/+/b57300894f57164a7edf8d6189cf7fce0854ee57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -69 lines) Patch
M chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc View 3 chunks +89 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 5 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_view_impl.cc View 5 chunks +2 lines, -38 lines 0 comments Download
M content/renderer/render_widget.h View 4 chunks +12 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M content/renderer/render_widget_owner_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/EditorClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/EditorClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/EditorClientImpl.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
alexmos
4 years, 3 months ago (2016-09-15 22:16:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b57300894f57164a7edf8d6189cf7fce0854ee57.

Powered by Google App Engine
This is Rietveld 408576698