CC: Add a scheduled action for ManageTiles

cc/trees/thread_proxy.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/thread_proxy.h"
 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 520 matching lines @@
   DCHECK(IsMainThread());
   return commit_requested_;
 }
 
 void ThreadProxy::SetNeedsRedrawOnImplThread() {
   DCHECK(IsImplThread());
   TRACE_EVENT0("cc", "ThreadProxy::SetNeedsRedrawOnImplThread");
   scheduler_on_impl_thread_->SetNeedsRedraw();
 }
 
+void ThreadProxy::SetNeedsManageTilesOnImplThread() {
+  DCHECK(IsImplThread());
+  TRACE_EVENT0("cc", "ThreadProxy::SetNeedsManageTilesOnImplThread");
+  scheduler_on_impl_thread_->SetNeedsManageTiles();
+}
+
 void ThreadProxy::SetNeedsRedrawRectOnImplThread(gfx::Rect damage_rect) {
   DCHECK(IsImplThread());
   layer_tree_host_impl_->SetViewportDamage(damage_rect);
   SetNeedsRedrawOnImplThread();
 }
 
 void ThreadProxy::SetSwapUsedIncompleteTileOnImplThread(
     bool used_incomplete_tile) {
   DCHECK(IsImplThread());
   if (used_incomplete_tile) {
@@ skipping 579 matching lines @@
                                base::TimeDelta::FromMilliseconds(1),
                                base::TimeDelta::FromMilliseconds(100),
                                50);
     UMA_HISTOGRAM_CUSTOM_TIMES("Renderer.DrawDurationOverestimate",
                                draw_duration_overestimate,
                                base::TimeDelta::FromMilliseconds(1),
                                base::TimeDelta::FromMilliseconds(100),
                                50);
   }
 
-  // Update the tile state after drawing.  This prevents manage tiles from
-  // being in the critical path for getting things on screen, but still
-  // makes sure that tile state is updated on a semi-regular basis.
-  if (layer_tree_host_impl_->settings().impl_side_painting)
-    layer_tree_host_impl_->ManageTiles();
-
   return result;
 }
 
 void ThreadProxy::AcquireLayerTextures() {
   // Called when the main thread needs to modify a layer texture that is used
   // directly by the compositor.
   // This method will block until the next compositor draw if there is a
   // previously committed frame that is still undrawn. This is necessary to
   // ensure that the main thread does not monopolize access to the textures.
   DCHECK(IsMainThread());
@@ skipping 24 matching lines @@
   texture_acquisition_completion_event_on_impl_thread_ = completion;
   scheduler_on_impl_thread_->SetMainThreadNeedsLayerTextures();
 }
 
 void ThreadProxy::ScheduledActionAcquireLayerTexturesForMainThread() {
   DCHECK(texture_acquisition_completion_event_on_impl_thread_);
   texture_acquisition_completion_event_on_impl_thread_->Signal();
   texture_acquisition_completion_event_on_impl_thread_ = NULL;
 }
 
+void ThreadProxy::ScheduledActionManageTiles() {
+  TRACE_EVENT0("cc", "ThreadProxy::ScheduledActionManageTiles");
+  // Only impl-side painting has threaded raster.
+  if (layer_tree_host_impl_->settings().impl_side_painting)

[reveman, 2013/09/11 15:27:45]

nit: maybe move this conditional to LTHI where we already have a lot of
impl-side painting conditional code. Also, can this be a DCHECK instead?

[brianderson, 2013/09/11 17:10:30]

Should we also have a DCHECK to make sure SetNeedsManageTilesOnImplThread only
occurs when impl-side-painting?

[epennerAtGoogle, 2013/09/11 18:43:00]

Done.

[epennerAtGoogle, 2013/09/11 18:43:00]

Done.

+    layer_tree_host_impl_->ManageTiles();
+}
+
 DrawSwapReadbackResult ThreadProxy::ScheduledActionDrawAndSwapIfPossible() {
   TRACE_EVENT0("cc", "ThreadProxy::ScheduledActionDrawAndSwap");
   bool forced_draw = false;
   bool swap_requested = true;
   bool readback_requested = false;
   return DrawSwapReadbackInternal(
       forced_draw, swap_requested, readback_requested);
 }
 
 DrawSwapReadbackResult ThreadProxy::ScheduledActionDrawAndSwapForced() {
@@ skipping 350 matching lines @@
     completion_event_for_commit_held_on_tree_activation_ = NULL;
   }
 
   UpdateBackgroundAnimateTicking();
 
   commit_to_activate_duration_history_.InsertSample(
       base::TimeTicks::HighResNow() - commit_complete_time_);
 }
 
 }  // namespace cc