Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2349473004: Revert of Preparse inner functions. (Closed)

Created:
4 years, 3 months ago by marja
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Preparse inner functions. (patchset #23 id:440001 of https://codereview.chromium.org/2322243002/ ) Reason for revert: This approach is not good - breaks when we recompile. Original issue's description: > Preparse inner functions. > > This is an overly pessimistic approach where PreParser only keeps > track of unresolved variables, but doesn't declare anything. This > will result in context-allocating variables in the outer function > unnecessarily, if the variable names clash with variable names > used by the inner function (even if the variables are not the > same). However, we have been unable to prove that this approach > wouldn't be good enough for the practical purposes. > > Committed: https://crrev.com/e1341ca8fa486bb2c9e4236672a64ec7756a164d > Cr-Commit-Position: refs/heads/master@{#39469} TBR=adamk@chromium.org,vogelheim@chromium.org,nikolaos@chromium.org,nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7de8639e517f319cddfe4f0b05725bb46fddd30e Cr-Commit-Position: refs/heads/master@{#39471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -183 lines) Patch
M src/ast/scopes.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 15 chunks +47 lines, -101 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +4 lines, -7 lines 0 comments Download
M src/parsing/preparser.h View 6 chunks +13 lines, -15 lines 0 comments Download
M src/parsing/preparser.cc View 4 chunks +16 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
marja
Created Revert of Preparse inner functions.
4 years, 3 months ago (2016-09-16 10:43:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349473004/1
4 years, 3 months ago (2016-09-16 10:43:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 10:43:29 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 10:44:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7de8639e517f319cddfe4f0b05725bb46fddd30e
Cr-Commit-Position: refs/heads/master@{#39471}

Powered by Google App Engine
This is Rietveld 408576698