Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Issue 2349473003: Revert of Adding target to build SwiftShader (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
sugoi1, sugoi
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding target to build SwiftShader (patchset #4 id:60001 of https://codereview.chromium.org/2330173002/ ) Reason for revert: This seems to not build in our sysroot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/5244/steps/compile/logs/stdio Original issue's description: > Adding target to build SwiftShader > > Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. > > BUG=630728 > > Committed: https://crrev.com/72ce608cb69854a0029f019e67ddf1509c274f0a > Cr-Commit-Position: refs/heads/master@{#418934} TBR=sugoi@google.com,sugoi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630728 Committed: https://crrev.com/6e282042a9921e3f937e3e6d9e78b523d36b38c6 Cr-Commit-Position: refs/heads/master@{#419011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of Adding target to build SwiftShader
4 years, 3 months ago (2016-09-15 22:14:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349473003/1
4 years, 3 months ago (2016-09-15 22:14:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 22:15:53 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 22:17:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e282042a9921e3f937e3e6d9e78b523d36b38c6
Cr-Commit-Position: refs/heads/master@{#419011}

Powered by Google App Engine
This is Rietveld 408576698