chrome/browser/ui/tab_helpers.cc - Issue 2349473002: Implement native functions to query custom search engines for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 2349473002: Implement native functions to query custom search engines for Android (Closed)

Patch Set: merge native functions to return generic template url and let Java side to decide which list it sho… Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index f3e1ac645b167b493fdf90a0b041269af9fe9b7b..67fe1902f16791df8a697d2c6f618a59d7947bca 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -46,6 +46,7 @@

#include "chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h"

#include "chrome/browser/ui/prefs/prefs_tab_helper.h"

#include "chrome/browser/ui/search/search_tab_helper.h"

+#include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"

#include "chrome/browser/ui/tab_contents/core_tab_helper.h"

#include "chrome/browser/ui/tab_dialogs.h"

#include "chrome/common/chrome_switches.h"

@@ -81,7 +82,6 @@

#include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"

#include "chrome/browser/ui/hung_plugin_tab_helper.h"

#include "chrome/browser/ui/sad_tab_helper.h"

-#include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"

#include "chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h"

#include "components/pdf/browser/pdf_web_contents_helper.h"

#include "components/web_modal/web_contents_modal_dialog_manager.h"

@@ -187,6 +187,7 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

prerender::PrerenderTabHelper::CreateForWebContents(web_contents);

PreviewsInfoBarTabHelper::CreateForWebContents(web_contents);

SearchTabHelper::CreateForWebContents(web_contents);

+ SearchEngineTabHelper::CreateForWebContents(web_contents);

ChromeSecurityStateModelClient::CreateForWebContents(web_contents);

if (SiteEngagementService::IsEnabled())

SiteEngagementService::Helper::CreateForWebContents(web_contents);

@@ -228,7 +229,6 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

PluginObserver::CreateForWebContents(web_contents);

SadTabHelper::CreateForWebContents(web_contents);

safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents);

- SearchEngineTabHelper::CreateForWebContents(web_contents);

TabContentsSyncedTabDelegate::CreateForWebContents(web_contents);

TabDialogs::CreateForWebContents(web_contents);

ThumbnailTabHelper::CreateForWebContents(web_contents);