Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2349473002: Implement native functions to query custom search engines for Android (Closed)

Created:
4 years, 3 months ago by ltian
Modified:
4 years, 3 months ago
Reviewers:
Ian Wen, Peter Kasting, gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement native functions to query custom search engines for Android 1. Enable SearchEngineTabHelper on Android to auto-detect and fetch OpenSearch description document. 2. Add native function to retrieve recent visited search engines. 3. Allow recent visited search engine to be selected as default search engine. BUG=348360 Committed: https://crrev.com/aa36cbaa608461565b798d847494d9be25cd15c8 Cr-Commit-Position: refs/heads/master@{#419569}

Patch Set 1 #

Total comments: 8

Patch Set 2 : delete Java file change because it is only related to frontend #

Patch Set 3 : merge native functions to return generic template url and let Java side to decide which list it sho… #

Total comments: 8

Patch Set 4 : update based on ian's comments #

Total comments: 4

Patch Set 5 : run "git cl format" to format the commit #

Messages

Total messages: 30 (12 generated)
ltian
4 years, 3 months ago (2016-09-15 21:47:47 UTC) #4
Ian Wen
https://codereview.chromium.org/2349473002/diff/1/chrome/browser/search_engines/template_url_service_android.cc File chrome/browser/search_engines/template_url_service_android.cc (right): https://codereview.chromium.org/2349473002/diff/1/chrome/browser/search_engines/template_url_service_android.cc#newcode125 chrome/browser/search_engines/template_url_service_android.cc:125: //search engine to adapt consistent design with desktop. Remove ...
4 years, 3 months ago (2016-09-15 22:26:03 UTC) #8
Ian Wen
https://codereview.chromium.org/2349473002/diff/1/chrome/browser/ui/tab_helpers.cc File chrome/browser/ui/tab_helpers.cc (right): https://codereview.chromium.org/2349473002/diff/1/chrome/browser/ui/tab_helpers.cc#newcode49 chrome/browser/ui/tab_helpers.cc:49: #include "chrome/browser/ui/search_engines/search_engine_tab_helper.h" On 2016/09/15 22:26:03, Ian Wen wrote: > ...
4 years, 3 months ago (2016-09-15 22:26:48 UTC) #9
Ian Wen
BTW I would rename the CL to something like "Enable web-fetched search engines on Android". ...
4 years, 3 months ago (2016-09-15 22:28:23 UTC) #10
ltian
4 years, 3 months ago (2016-09-15 22:28:35 UTC) #12
Peter Kasting
I got added as a reviewer with no comment. Please clarify what you're looking for ...
4 years, 3 months ago (2016-09-15 22:50:50 UTC) #13
ltian
On 2016/09/15 22:50:50, Peter Kasting wrote: > I got added as a reviewer with no ...
4 years, 3 months ago (2016-09-15 23:16:52 UTC) #14
Peter Kasting
On 2016/09/15 23:16:52, ltian wrote: > On 2016/09/15 22:50:50, Peter Kasting wrote: > > I ...
4 years, 3 months ago (2016-09-15 23:18:10 UTC) #15
ltian
https://codereview.chromium.org/2349473002/diff/1/chrome/browser/search_engines/template_url_service_android.cc File chrome/browser/search_engines/template_url_service_android.cc (right): https://codereview.chromium.org/2349473002/diff/1/chrome/browser/search_engines/template_url_service_android.cc#newcode125 chrome/browser/search_engines/template_url_service_android.cc:125: //search engine to adapt consistent design with desktop. On ...
4 years, 3 months ago (2016-09-16 00:23:18 UTC) #16
Ian Wen
https://chromiumcodereview.appspot.com/2349473002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java File chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java (right): https://chromiumcodereview.appspot.com/2349473002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java#newcode50 chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:50: private boolean mIsDefault; s/mIsDefault/mIsPrepopulated https://chromiumcodereview.appspot.com/2349473002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java#newcode133 chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:133: TemplateUrl templateUrl = ...
4 years, 3 months ago (2016-09-16 20:43:04 UTC) #17
ltian
https://codereview.chromium.org/2349473002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java File chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java (right): https://codereview.chromium.org/2349473002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java#newcode50 chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:50: private boolean mIsDefault; On 2016/09/16 20:43:04, Ian Wen wrote: ...
4 years, 3 months ago (2016-09-16 21:39:10 UTC) #18
Ian Wen
https://codereview.chromium.org/2349473002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java File chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java (right): https://codereview.chromium.org/2349473002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java#newcode54 chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:54: int id, String shortName, boolean isPrepopulated) { nit: move ...
4 years, 3 months ago (2016-09-16 21:54:07 UTC) #19
ltian
https://codereview.chromium.org/2349473002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java File chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java (right): https://codereview.chromium.org/2349473002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java#newcode54 chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:54: int id, String shortName, boolean isPrepopulated) { On 2016/09/16 ...
4 years, 3 months ago (2016-09-16 22:14:09 UTC) #20
Ian Wen
lgtm. Passing it to dfalcantara@ for owner stamp.
4 years, 3 months ago (2016-09-16 22:25:35 UTC) #22
gone
lgtm
4 years, 3 months ago (2016-09-19 16:59:40 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349473002/80001
4 years, 3 months ago (2016-09-19 18:42:04 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-19 21:42:51 UTC) #28
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:45:32 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/aa36cbaa608461565b798d847494d9be25cd15c8
Cr-Commit-Position: refs/heads/master@{#419569}

Powered by Google App Engine
This is Rietveld 408576698