Index: components/plugins/renderer/webview_plugin.h |
diff --git a/components/plugins/renderer/webview_plugin.h b/components/plugins/renderer/webview_plugin.h |
index f73df622784cc8fee3c832abb10030893197a951..d6814c956f72521e76bad965676d92424b11c461 100644 |
--- a/components/plugins/renderer/webview_plugin.h |
+++ b/components/plugins/renderer/webview_plugin.h |
@@ -108,6 +108,11 @@ class WebViewPlugin : public blink::WebPlugin, |
const blink::WebInputEvent& event, |
blink::WebCursorInfo& cursor_info) override; |
+ // didReceiveResponse() overrides both WebPlugin and WebFrameClient. |
+ // The WebFrameClient variant receives callbacks, but the WebPlugin variant |
+ // shouldn't. |
+ // TODO(japhet): WebViewPlugin shouldn't be a WebFrameClient, after which |
+ // didReceiveResponse() should have a NOTREACHED(). |
void didReceiveResponse(const blink::WebURLResponse& response) override {} |
void didReceiveData(const char* data, int data_length) override; |
void didFinishLoading() override; |