Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: components/plugins/renderer/webview_plugin.h

Issue 2349443003: Listen to didReceiveResponse() to get the response in WebViewPlugin. (Closed)
Patch Set: +comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/plugins/renderer/webview_plugin.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_ 5 #ifndef COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
6 #define COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_ 6 #define COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
7 7
8 #include <list> 8 #include <list>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 const blink::WebVector<blink::WebRect>& cut_outs_rects, 101 const blink::WebVector<blink::WebRect>& cut_outs_rects,
102 bool is_visible) override; 102 bool is_visible) override;
103 103
104 void updateFocus(bool foucsed, blink::WebFocusType focus_type) override; 104 void updateFocus(bool foucsed, blink::WebFocusType focus_type) override;
105 void updateVisibility(bool) override {} 105 void updateVisibility(bool) override {}
106 106
107 blink::WebInputEventResult handleInputEvent( 107 blink::WebInputEventResult handleInputEvent(
108 const blink::WebInputEvent& event, 108 const blink::WebInputEvent& event,
109 blink::WebCursorInfo& cursor_info) override; 109 blink::WebCursorInfo& cursor_info) override;
110 110
111 // didReceiveResponse() overrides both WebPlugin and WebFrameClient.
112 // The WebFrameClient variant receives callbacks, but the WebPlugin variant
113 // shouldn't.
114 // TODO(japhet): WebViewPlugin shouldn't be a WebFrameClient, after which
115 // didReceiveResponse() should have a NOTREACHED().
111 void didReceiveResponse(const blink::WebURLResponse& response) override {} 116 void didReceiveResponse(const blink::WebURLResponse& response) override {}
112 void didReceiveData(const char* data, int data_length) override; 117 void didReceiveData(const char* data, int data_length) override;
113 void didFinishLoading() override; 118 void didFinishLoading() override;
114 void didFailLoading(const blink::WebURLError& error) override; 119 void didFailLoading(const blink::WebURLError& error) override;
115 120
116 // WebViewClient methods: 121 // WebViewClient methods:
117 bool acceptsLoadDrops() override; 122 bool acceptsLoadDrops() override;
118 123
119 void setToolTipText(const blink::WebString&, 124 void setToolTipText(const blink::WebString&,
120 blink::WebTextDirection) override; 125 blink::WebTextDirection) override;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 bool finished_loading_; 180 bool finished_loading_;
176 bool focused_; 181 bool focused_;
177 bool is_painting_; 182 bool is_painting_;
178 bool is_resizing_; 183 bool is_resizing_;
179 184
180 // Should be invalidated when destroy() is called. 185 // Should be invalidated when destroy() is called.
181 base::WeakPtrFactory<WebViewPlugin> weak_factory_; 186 base::WeakPtrFactory<WebViewPlugin> weak_factory_;
182 }; 187 };
183 188
184 #endif // COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_ 189 #endif // COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
OLDNEW
« no previous file with comments | « no previous file | components/plugins/renderer/webview_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698