Listen to didReceiveResponse() to get the response in WebViewPlugin.

components/plugins/renderer/webview_plugin.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/plugins/renderer/webview_plugin.h"
 
 #include <stddef.h>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 77 matching lines @@
 }
 
 WebViewPlugin::~WebViewPlugin() {
   DCHECK(!weak_factory_.HasWeakPtrs());
   web_frame_widget_->close();
   web_view_->close();
   web_frame_->close();
 }
 
 void WebViewPlugin::ReplayReceivedData(WebPlugin* plugin) {
-  const WebURLResponse& response = web_frame_->dataSource()->response();
-  if (!response.isNull()) {
-    plugin->didReceiveResponse(response);
+  if (!response_.isNull()) {
+    plugin->didReceiveResponse(response_);
     size_t total_bytes = 0;
     for (std::list<std::string>::iterator it = data_.begin(); it != data_.end();
          ++it) {
       plugin->didReceiveData(
           it->c_str(), base::checked_cast<int, size_t>(it->length()));
       total_bytes += it->length();
     }
     UMA_HISTOGRAM_MEMORY_KB(
         "PluginDocument.Memory",
         (base::checked_cast<int, size_t>(total_bytes / 1024)));
     UMA_HISTOGRAM_COUNTS(
         "PluginDocument.NumChunks",
         (base::checked_cast<int, size_t>(data_.size())));
   }
   // We need to transfer the |focused_| to new plugin after it loaded.
   if (focused_) {
     plugin->updateFocus(true, blink::WebFocusTypeNone);
   }
   if (finished_loading_) {
     plugin->didFinishLoading();
   }
   if (error_) {
     plugin->didFailLoading(*error_);
   }
 }
 
+void WebViewPlugin::didReceiveResponse(const WebURLResponse& response) {
+  if (!response_.isNull())

[tommycli, 2016/09/15 23:53:35]

This line used to be DCHECK(response_.isNull());

Did you mean "response" the function argument instead of the member var?

[tommycli, 2016/09/16 00:01:38]

Restoring the old DCHECK crashes, so I'm guessing something has changed about
how these responses work.

The patch as-is works, but I'm not sure, since it would seem that
response_.isNull() would be initially true, and the member variable would never
be populated.

[Bernhard Bauer, 2016/09/16 10:28:01]

Huh, that's strange. Where would the non-null value come from? Is this being
called more than once now?

[Nate Chapin, 2016/09/16 17:17:54]

Yeah this patchset only works accidentally: I inverted the if() statement, and
therefore response_ will always be null. To understand why this fixes the issue,
let's start at the beginning!

While I was working on
https://crrev.com/8489f1bf78c2c6f296e0df6c529751d29e8a0188, I ran into a
problem: I had changed WebFrameClient::didReceiveResponse() to just have a
single const WebURLResponse& parameter. This meant that WebViewPlugin had a
diamond inheritance problem, as it implements both WebFrameClient and WebPlugin,
and both of these functions now had a didReceiveResponse() callback with
identical parameters.

I believe the key is that the WebPlugin::didReceiveResponse() callback was
*never* getting called for a WebViewPlugin. WebViewPlugin initializes its frame
with a data: url, so a PluginDocument isn't created in blink, and without a
PluginDocument, there are no WebPlugin::didReceiveResponse() callbacks. But with
the diamond inheritance, it was now picking up the response from the
WebFrameClient::didReceiveResponse() callbacks, none of which are actually the
plugin data. I settled on "fixing" this in
https://crrev.com/8489f1bf78c2c6f296e0df6c529751d29e8a0188 by getting an
irrelevant WebURLResponse a different way, not realizing that all of
WebViewPlugin's response handling is dead code.

So I goofed in that patch, and it appears this patchset fixes the issue by
introducing different, subtly dead code. I believe the right solution is to
simply remove any logic that handles a WebURLResponse. Updated patch to reflect
that. There is probably more to remove, but I'll stick to that in this patch.

+    response_ = response;
+}
+
 void WebViewPlugin::RestoreTitleText() {
   if (container_)
     container_->element().setAttribute("title", old_title_);
 }
 
 WebPluginContainer* WebViewPlugin::container() const { return container_; }
 
 bool WebViewPlugin::initialize(WebPluginContainer* container) {
   DCHECK(container);
   DCHECK_EQ(this, container->plugin());
@@ skipping 212 matching lines @@
   if (!delegate_)
     return;
 
   // The delegate may instantiate a new plugin.
   delegate_->OnUnobscuredRectUpdate(gfx::Rect(unobscured_rect));
   // The delegate may have dirtied style and layout of the WebView.
   // See for example the resizePoster function in plugin_poster.html.
   // Run the lifecycle now so that it is clean.
   web_view_->updateAllLifecyclePhases();
 }