Minor IndexedDB refactorings.

third_party/WebKit/Source/modules/indexeddb/IDBIndex.h

Index: third_party/WebKit/Source/modules/indexeddb/IDBIndex.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBIndex.h b/third_party/WebKit/Source/modules/indexeddb/IDBIndex.h
index 77c907c495641f8871b9c0721d06f2e45d7b9065..3ba6922ce14a1ee5856388e7cce4147a911b30d0 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBIndex.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBIndex.h
@@ -53,13 +53,15 @@ public:
     ~IDBIndex();
     DECLARE_TRACE();
 
+    const IDBIndexMetadata& metadata() const { return m_metadata; }

[cmumford, 2016/09/19 23:26:48]

I also don't see the need for this method. Seems to just add another layer of
indirection and is only used by IDBIndex - so could be private.

[pwnall, 2016/09/20 09:11:14]

The main benefit here is also being able to switch the metadata type without as
much code churn.

I made the method private. Is this reasonable?

+
     // Implement the IDL
-    const String& name() const { return m_metadata.name; }
+    const String& name() const { return metadata().name; }
     void setName(const String& name, ExceptionState&);
     IDBObjectStore* objectStore() const { return m_objectStore.get(); }
     ScriptValue keyPath(ScriptState*) const;
-    bool unique() const { return m_metadata.unique; }
-    bool multiEntry() const { return m_metadata.multiEntry; }
+    bool unique() const { return metadata().unique; }
+    bool multiEntry() const { return metadata().multiEntry; }
 
     IDBRequest* openCursor(ScriptState*, const ScriptValue& key, const String& direction, ExceptionState&);
     IDBRequest* openKeyCursor(ScriptState*, const ScriptValue& range, const String& direction, ExceptionState&);
@@ -73,7 +75,7 @@ public:
 
     void markDeleted() { m_deleted = true; }
     bool isDeleted() const;
-    int64_t id() const { return m_metadata.id; }
+    int64_t id() const { return metadata().id; }
 
     // Used internally and by InspectorIndexedDBAgent:
     IDBRequest* openCursor(ScriptState*, IDBKeyRange*, WebIDBCursorDirection);