Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 23494067: Revert "libpng 1.6.3" (Closed)

Created:
7 years, 3 months ago by loislo
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert "libpng 1.6.3" This reverts commit 777c940a87944192afaa28904c30145bfeb54d09. Many Blink LayoutTests starts failing after this patch. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=canvas/philip/tests/security.dataURI.html,canvas/philip/tests/toDataURL.arguments.1.html,canvas/philip/tests/toDataURL.arguments.2.html,canvas/philip/tests/toDataURL.arguments.3.html,canvas/philip/tests/toDataURL.bogustype.html,canvas/philip/tests/toDataURL.default.html,canvas/philip/tests/toDataURL.lowercase.ascii.html,canvas/philip/tests/toDataURL.lowercase.unicode.html,canvas/philip/tests/toDataURL.nocontext.html,canvas/philip/tests/toDataURL.png.complexcolours.html,canvas/philip/tests/toDataURL.png.html,canvas/philip/tests/toDataURL.png.primarycolours.html,canvas/philip/tests/toDataURL.unrecognised.html,compositing/overflow/image-load-overflow-scrollbars.html,compositing/overflow/invisible-descendants-should-not-affect-opt-in.html,compositing/tiling/huge-layer-img.html,css2.1/20110323/inline-replaced-width-014.htm,css2.1/t0905-c414-flt-wrap-01-d-g.html,fast/backgrounds/bgCompositeCopy.html,fast/canvas/canvas-blending-color-over-image.html,fast/canvas/canvas-blending-color-over-pattern.html,fast/canvas/canvas-blending-gradient-over-image.html,fast/canvas/canvas-blending-gradient-over-pattern.html,fast/canvas/canvas-blending-image-over-color.html,fast/canvas/canvas-blending-image-over-gradient.html,fast/canvas/canvas-blending-image-over-image.html,fast/canvas/canvas-blending-image-over-pattern.html,fast/canvas/canvas-blending-pattern-over-color.html,fast/canvas/canvas-blending-pattern-over-gradient.html,fast/canvas/canvas-blending-pattern-over-image.html,fast/canvas/canvas-blending-pattern-over-pattern.html,fast/canvas/canvas-createImageBitmap-drawImage.html,fast/canvas/canvas-createImageBitmap-immutable.html,fast/canvas/canvas-createImageBitmap-invalid-args.html,fast/canvas/canvas-createImageBitmap-out-of-bounds-src.html,fast/canvas/canvas-createImageBitmap-recursive.html,fast/canvas/canvas-createPattern-fillRect-shadow.html,fast/canvas/canvas-drawImage-out-of-bounds-src.html,fast/canvas/canvas-drawImage-shadow.html,fast/canvas/canvas-scale-drawImage-shadow.html,fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html,fast/canvas/check-stale-putImageData.html,fast/canvas/toDataURL-alpha.html,fast/canvas/toDataURL-supportedTypes.html,fast/canvas/webgl/gl-teximage.html,fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html,fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html,fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html,fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html,fast/css/color-correction-on-backgrounds.html,fast/css/color-correction.html,fast/images/paint-subrect-grid.html,fast/images/png-suite/test.html,fast/images/png-with-color-profile.html,fast/images/rgb-png-with-cmyk-color-profile.html,inspector/profiler/canvas2d/canvas-get-resource-state.html,inspector/profiler/webgl/webgl-get-resource-state.html,svg/W3C-SVG-1.1/filters-blend-01-b.svg,svg/W3C-SVG-1.1/masking-path-04-b.svg,svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html,svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html,svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html,svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html,svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html,svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html,virtual/deferred/fast/images/paint-subrect-grid.html,virtual/deferred/fast/images/png-suite/test.html,virtual/deferred/fast/images/png-with-color-profile.html,virtual/deferred/fast/images/rgb-png-with-cmyk-color-profile.html,virtual/gpu/canvas/philip/tests/security.dataURI.html,virtual/gpu/canvas/philip/tests/toDataURL.arguments.1.html,virtual/gpu/canvas/philip/tests/toDataURL.arguments.2.html,virtual/gpu/canvas/philip/tests/toDataURL.arguments.3.html,virtual/gpu/canvas/philip/tests/toDataURL.bogustype.html,virtual/gpu/canvas/philip/tests/toDataURL.default.html,virtual/gpu/canvas/philip/tests/toDataURL.lowercase.ascii.html,virtual/gpu/canvas/philip/tests/toDataURL.lowercase.unicode.html,virtual/gpu/canvas/philip/tests/toDataURL.nocontext.html,virtual/gpu/canvas/philip/tests/toDataURL.png.complexcolours.html,virtual/gpu/canvas/philip/tests/toDataURL.png.html,virtual/gpu/canvas/philip/tests/toDataURL.png.primarycolours.html,virtual/gpu/canvas/philip/tests/toDataURL.unrecognised.html,virtual/gpu/compositedscrolling/overflow/image-load-overflow-scrollbars.html,virtual/gpu/compositedscrolling/overflow/invisible-descendants-should-not-affect-opt-in.html,virtual/gpu/fast/canvas/canvas-blending-color-over-image.html,virtual/gpu/fast/canvas/canvas-blending-color-over-pattern.html,virtual/gpu/fast/canvas/canvas-blending-gradient-over-image.html,virtual/gpu/fast/canvas/canvas-blending-gradient-over-pattern.html,virtual/gpu/fast/canvas/canvas-blending-image-over-color.html,virtual/gpu/fast/canvas/canvas-blending-image-over-gradient.html,virtual/gpu/fast/canvas/canvas-blending-image-over-image.html,virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html,virtual/gpu/fast/canvas/canvas-blending-pattern-over-color.html,virtual/gpu/fast/canvas/canvas-blending-pattern-over-gradient.html,virtual/gpu/fast/canvas/canvas-blending-pattern-over-image.html,virtual/gpu/fast/canvas/canvas-blending-pattern-over-pattern.html,virtual/gpu/fast/canvas/canvas-createImageBitmap-drawImage.html,virtual/gpu/fast/canvas/canvas-createImageBitmap-immutable.html,virtual/gpu/fast/canvas/canvas-createImageBitmap-invalid-args.html,virtual/gpu/fast/canvas/canvas-createImageBitmap-out-of-bounds-src.html,virtual/gpu/fast/canvas/canvas-createImageBitmap-recursive.html,virtual/gpu/fast/canvas/canvas-createPattern-fillRect-shadow.html,virtual/gpu/fast/canvas/canvas-drawImage-out-of-bounds-src.html,virtual/gpu/fast/canvas/canvas-scale-drawImage-shadow.html,virtual/gpu/fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html,virtual/gpu/fast/canvas/check-stale-putImageData.html,virtual/gpu/fast/canvas/toDataURL-alpha.html,virtual/gpu/fast/canvas/toDataURL-supportedTypes.html,virtual/gpu/fast/canvas/webgl/gl-teximage.html,virtual/gpu/fast/canvas/webgl/premultiplyalpha-test.html,virtual/gpu/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html,virtual/gpu/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html,virtual/gpu/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html,virtual/gpu/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html,virtual/softwarecompositing/overflow/image-load-overflow-scrollbars.html,virtual/softwarecompositing/overflow/invisible-descendants-should-not-affect-opt-in.html,virtual/softwarecompositing/tiling/huge-layer-img.html BUG=none TBR= dominikg@chromium.org, arv@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14313 lines, -24762 lines) Patch
M third_party/libpng/LICENSE View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/libpng/README View 7 chunks +111 lines, -38 lines 0 comments Download
M third_party/libpng/README.chromium View 2 chunks +1 line, -4 lines 0 comments Download
D third_party/libpng/arm/arm_init.c View 1 chunk +0 lines, -221 lines 0 comments Download
D third_party/libpng/arm/filter_neon.S View 1 chunk +0 lines, -237 lines 0 comments Download
M third_party/libpng/libpng.gyp View 2 chunks +3 lines, -12 lines 0 comments Download
M third_party/libpng/png.h View 33 chunks +2560 lines, -2077 lines 0 comments Download
M third_party/libpng/png.c View 23 chunks +585 lines, -3783 lines 0 comments Download
M third_party/libpng/pngconf.h View 2 chunks +1543 lines, -495 lines 0 comments Download
D third_party/libpng/pngdebug.h View 1 chunk +0 lines, -157 lines 0 comments Download
M third_party/libpng/pngerror.c View 11 chunks +156 lines, -692 lines 0 comments Download
M third_party/libpng/pngget.c View 19 chunks +330 lines, -563 lines 0 comments Download
D third_party/libpng/pnginfo.h View 1 chunk +0 lines, -260 lines 0 comments Download
D third_party/libpng/pnglibconf.h View 1 chunk +0 lines, -480 lines 0 comments Download
M third_party/libpng/pngmem.c View 4 chunks +511 lines, -147 lines 0 comments Download
M third_party/libpng/pngpread.c View 58 chunks +823 lines, -340 lines 0 comments Download
D third_party/libpng/pngpriv.h View 1 chunk +0 lines, -2006 lines 0 comments Download
M third_party/libpng/pngread.c View 16 chunks +871 lines, -3343 lines 0 comments Download
M third_party/libpng/pngrio.c View 6 chunks +80 lines, -18 lines 0 comments Download
M third_party/libpng/pngrtran.c View 114 chunks +1718 lines, -2352 lines 0 comments Download
M third_party/libpng/pngrutil.c View 48 chunks +1681 lines, -2756 lines 0 comments Download
M third_party/libpng/pngset.c View 13 chunks +593 lines, -964 lines 0 comments Download
D third_party/libpng/pngstruct.h View 1 chunk +0 lines, -489 lines 0 comments Download
M third_party/libpng/pngtrans.c View 21 chunks +232 lines, -374 lines 0 comments Download
M third_party/libpng/pngusr.h View 1 chunk +448 lines, -1 line 0 comments Download
M third_party/libpng/pngwio.c View 7 chunks +125 lines, -29 lines 0 comments Download
M third_party/libpng/pngwrite.c View 39 chunks +721 lines, -1458 lines 0 comments Download
M third_party/libpng/pngwtran.c View 28 chunks +85 lines, -140 lines 0 comments Download
M third_party/libpng/pngwutil.c View 71 chunks +1131 lines, -1322 lines 0 comments Download
M third_party/zlib/zlib.gyp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
loislo
Committed patchset #1 manually as r224979 (presubmit successful).
7 years, 3 months ago (2013-09-24 11:14:54 UTC) #1
loislo
7 years, 3 months ago (2013-09-24 11:26:43 UTC) #2
arv (Not doing code reviews)
LGTM
7 years, 3 months ago (2013-09-24 15:35:49 UTC) #3
Dominik Grewe
7 years, 3 months ago (2013-09-24 16:48:23 UTC) #4
Message was sent while issue was closed.
Sorry about that.
Are the Blink LayoutTests not run on the try bots when submitting? I'll try to
fix the patch when I'm back in the office next week and I'll make sure to run
the LayoutTests locally.

Powered by Google App Engine
This is Rietveld 408576698