sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 23494057: We can only use JavaScript's String.split and String.+ if both inputs are Strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 23494057: We can only use JavaScript's String.split and String.+ if both inputs are Strings. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart ('k') | tests/corelib/string_operations_with_null_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 27517)

+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)

@@ -299,13 +299,17 @@

}

} else if (input.isString(compiler)) {

if (selector.applies(backend.jsStringSplit, compiler)) {

- if (node.inputs[2].isString(compiler)) {

+ HInstruction argument = node.inputs[2];

+ if (argument.isString(compiler) && !argument.canBeNull()) {

target = backend.jsStringSplit;

}

} else if (selector.applies(backend.jsStringOperatorAdd, compiler)) {

// `operator+` is turned into a JavaScript '+' so we need to

- // make sure the receiver is not null.

- if (node.inputs[2].isString(compiler) && !input.canBeNull()) {

+ // make sure the receiver and the argument are not null.

+ HInstruction argument = node.inputs[2];

+ if (argument.isString(compiler)

+ && !argument.canBeNull()

+ && !input.canBeNull()) {

target = backend.jsStringOperatorAdd;

}

} else if (selector.applies(backend.jsStringToString, compiler)