Remove NOTIFICATION_SYSTEM_SETTING_CHANGED, switch CrosSettings to base::CallbackRegistry.

chrome/browser/chromeos/login/wallpaper_manager.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/wallpaper_manager.h"
 
 #include <vector>
 
 #include "ash/shell.h"
 #include "base/command_line.h"
@@ skipping 144 matching lines @@
 
 WallpaperManager::~WallpaperManager() {
   // TODO(bshe): Lifetime of WallpaperManager needs more consideration.
   // http://crbug.com/171694
   DCHECK(no_observers_);
   ClearObsoleteWallpaperPrefs();
   weak_factory_.InvalidateWeakPtrs();
 }
 
 void WallpaperManager::Shutdown() {
-  CrosSettings::Get()->RemoveSettingsObserver(
-      kAccountsPrefShowUserNamesOnSignIn, this);
+  show_user_name_on_signin_subscription_.reset();
   no_observers_ = true;

[Mattias Nissler (ping if slow), 2013/09/18 09:09:48]

You probably want to nuke |no_observers_| and replace the DCHECK in line 159
with DCHECK(!show_user_name_on_signin_subscription_).

[Avi (use Gerrit), 2013/09/18 16:41:44]

Done.

 }
 
 // static
 void WallpaperManager::RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterDictionaryPref(prefs::kUsersWallpaperInfo);
   registry->RegisterDictionaryPref(kUserWallpapers);
   registry->RegisterDictionaryPref(kUserWallpapersProperties);
 }
 
 void WallpaperManager::AddObservers() {
-  CrosSettings::Get()->AddSettingsObserver(kAccountsPrefShowUserNamesOnSignIn,
-                                           this);
+  show_user_name_on_signin_subscription_ =
+      CrosSettings::Get()->AddSettingsObserver(
+          kAccountsPrefShowUserNamesOnSignIn,
+          base::Bind(&WallpaperManager::InitializeRegisteredDeviceWallpaper,
+                     base::Unretained(this)));
   no_observers_ = false;
 }
 
 void WallpaperManager::EnsureLoggedInUserWallpaperLoaded() {
   // Some browser tests do not have a shell instance. As no wallpaper is needed
   // in these tests anyway, avoid loading one, preventing crashes and speeding
   // up the tests.
   if (!ash::Shell::HasInstance())
     return;
 
@@ skipping 127 matching lines @@
       if (should_cache_wallpaper_) {
         BrowserThread::PostDelayedTask(
             BrowserThread::UI, FROM_HERE,
             base::Bind(&WallpaperManager::CacheUsersWallpapers,
                        weak_factory_.GetWeakPtr()),
             base::TimeDelta::FromMilliseconds(kCacheWallpaperDelayMs));
         should_cache_wallpaper_ = false;
       }
       break;
     }
-    case chrome::NOTIFICATION_SYSTEM_SETTING_CHANGED: {
-      if (*content::Details<const std::string>(details).ptr() ==
-          kAccountsPrefShowUserNamesOnSignIn) {
-        InitializeRegisteredDeviceWallpaper();
-      }
-      break;
-    }
     default:
       NOTREACHED() << "Unexpected notification " << type;
   }
 }
 
 void WallpaperManager::RemoveUserWallpaperInfo(const std::string& email) {
   PrefService* prefs = g_browser_process->local_state();
   DictionaryPrefUpdate prefs_wallpapers_info_update(prefs,
       prefs::kUsersWallpaperInfo);
   prefs_wallpapers_info_update->RemoveWithoutPathExpansion(email, NULL);
@@ skipping 747 matching lines @@
   // |sequence_token_| here.
   wallpaper_loader_->Start(wallpaper_path.value(), 0, sequence_token_,
                            base::Bind(&WallpaperManager::OnWallpaperDecoded,
                                       base::Unretained(this),
                                       email,
                                       info.layout,
                                       update_wallpaper));
 }
 
 }  // namespace chromeos