Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: runtime/bin/process_macos.cc

Issue 23494048: Always wait for child processes when forked, even if the process failed. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/process_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_macos.cc
diff --git a/runtime/bin/process_macos.cc b/runtime/bin/process_macos.cc
index ff9a5245c732445845455cbfea7d3936d02da498..edb222af3fb11acc7037a1f9a813ba374529ea63 100644
--- a/runtime/bin/process_macos.cc
+++ b/runtime/bin/process_macos.cc
@@ -405,6 +405,9 @@ int Process::Start(const char* path,
ReportChildError(exec_control[1]);
}
+ // Be sure to listen for exit-codes, now we have a child-process.
+ ExitCodeHandler::ProcessStarted();
+
// The arguments and environment for the spawned process are not needed
// any longer.
delete[] program_arguments;
@@ -491,9 +494,6 @@ int Process::Start(const char* path,
*err = read_err[0];
VOID_TEMP_FAILURE_RETRY(close(read_err[1]));
- // Be sure to listen for exit-codes, now we have a child-process.
- ExitCodeHandler::ProcessStarted();
-
*id = pid;
return 0;
}
« no previous file with comments | « runtime/bin/process_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698