Split media::DemuxerAndroid implementation of BrowserMediaPlayerManager to BrowserDemuxerAndroid.

Split media::DemuxerAndroid implementation of BrowserMediaPlayerManager to BrowserDemuxerAndroid.

BUG=263652
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222713

[scherkus (not reviewing), 2013-09-10 01:13:37]

this represents the last bit of cleanup after introducing DemuxerAndroid

feel free to comment on the naming of the class

FWIW, the more traditional naming scheme for these classes would be:
browser: DemuxerDispatcherHost
renderer: DemuxerMessageFilter


... but I've never been overly fond of that naming scheme.

[scherkus (not reviewing), 2013-09-11 17:43:46]

acolwell/qinmin: this is now ready for review

[qinmin, 2013-09-11 18:09:46]

lgtm

[acolwell GONE FROM CHROMIUM, 2013-09-11 18:27:34]

lgtm

https://codereview.chromium.org/23494040/diff/11001/content/browser/android/b...
File content/browser/android/browser_media_player_manager.cc (right):

https://codereview.chromium.org/23494040/diff/11001/content/browser/android/b...
content/browser/android/browser_media_player_manager.cc:83: browser_demuxer_(new
BrowserDemuxerAndroid(render_view_host)),
This is odd to see the new here, but the comment in the .h file indicate the the
host owns this. :/ I would have expected the host to pass this in.

[scherkus (not reviewing), 2013-09-11 19:42:33]

https://codereview.chromium.org/23494040/diff/11001/content/browser/android/b...
File content/browser/android/browser_media_player_manager.cc (right):

https://codereview.chromium.org/23494040/diff/11001/content/browser/android/b...
content/browser/android/browser_media_player_manager.cc:83: browser_demuxer_(new
BrowserDemuxerAndroid(render_view_host)),
On 2013/09/11 18:27:34, acolwell wrote:
> This is odd to see the new here, but the comment in the .h file indicate the
the
> host owns this. :/ I would have expected the host to pass this in.

Yeah BMPM gets created via a static ::Create() method, which muddles things a
little bit.

This is going to change anyway after I switch from routed to control methods
since BDA will no longer be tied to a RenderViewHost so BMPM will have to grab
the BDA from the RenderProcessHostImpl

[scherkus (not reviewing), 2013-09-11 19:44:05]

jam: OWNERS review for content/

[jam, 2013-09-11 21:31:10]

On 2013/09/11 19:44:05, scherkus wrote:
> jam: OWNERS review for content/

since content/browser/android/OWNERS exists, please get someone from that to do
owners review of the new files there. or, expand the per-file rules for qinmin
since they don't cover this file now...

content_browser.gypi lgtm

[scherkus (not reviewing), 2013-09-11 22:15:21]

+yfriedman for content/browser/android/ + OWNERS change

perhaps in a follow up CL we can move media-related android file to
content/browser/media/ ?

[Yaron, 2013-09-12 00:13:44]

rubberstamp lgtm

move sgtm as well

[commit-bot: I haz the power, 2013-09-12 01:12:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/23494040/36001

[commit-bot: I haz the power, 2013-09-12 05:37:03]

Change committed as 222713