Source/devtools/front_end/HeapSnapshotGridNodes.js - Issue 23494034: HeapSnapshot: Sort by distance doesn't work properly for node children in Summary view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/HeapSnapshotGridNodes.js

Issue 23494034: HeapSnapshot: Sort by distance doesn't work properly for node children in Summary view. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/HeapSnapshotGridNodes.js

diff --git a/Source/devtools/front_end/HeapSnapshotGridNodes.js b/Source/devtools/front_end/HeapSnapshotGridNodes.js

index 8683d043b9f28fb102e246f167de394e94bb59e2..4f273812d60e3cb18381c8124cd0ec1e755dd0d9 100644

--- a/Source/devtools/front_end/HeapSnapshotGridNodes.js

+++ b/Source/devtools/front_end/HeapSnapshotGridNodes.js

@@ -812,7 +812,7 @@ WebInspector.HeapSnapshotConstructorNode.prototype = {

var sortColumnIdentifier = this._dataGrid.sortColumnIdentifier();

var sortFields = {

object: ["id", sortAscending, "retainedSize", false],

- distance: ["distance", true, "retainedSize", false],

+ distance: ["distance", sortAscending, "retainedSize", false],

count: ["id", true, "retainedSize", false],

shallowSize: ["selfSize", sortAscending, "id", true],

retainedSize: ["retainedSize", sortAscending, "id", true]

« no previous file with comments | « no previous file | no next file » | no next file with comments »