pkg/intl/lib/src/date_format_field.dart - Issue 23494030: Fix off-by-one error in computing the quarter in date formatting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/intl/lib/src/date_format_field.dart

Issue 23494030: Fix off-by-one error in computing the quarter in date formatting (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/intl/lib/src/date_format_field.dart

diff --git a/pkg/intl/lib/src/date_format_field.dart b/pkg/intl/lib/src/date_format_field.dart

index 08afc045765d650c5ebc2425a7116fd53712089f..fb8274ce1095f8b1c92db7fd241892028b6a60dd 100644

--- a/pkg/intl/lib/src/date_format_field.dart

+++ b/pkg/intl/lib/src/date_format_field.dart

@@ -345,7 +345,7 @@ class _DateFormatPatternField extends _DateFormatField {

}

String formatQuarter(DateTime date) {

- var quarter = (date.month / 3).truncate();

+ var quarter = ((date.month - 1) / 3).truncate();

if (width < 4) {

return symbols.SHORTQUARTERS[quarter];

} else {

« no previous file with comments | « no previous file | pkg/intl/test/date_time_format_test_core.dart » ('j') | no next file with comments »