pkg/analyzer_experimental/lib/src/generated/java_core.dart - Issue 23494027: Make LinkedHashMap also have a factory constructor and be customizable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer_experimental/lib/src/generated/java_core.dart

Issue 23494027: Make LinkedHashMap also have a factory constructor and be customizable (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart ('k') | pkg/mdv/lib/src/template_iterator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer_experimental/lib/src/generated/java_core.dart

diff --git a/pkg/analyzer_experimental/lib/src/generated/java_core.dart b/pkg/analyzer_experimental/lib/src/generated/java_core.dart

index d13bb3d72e1bf7812215b9c4cbbb41812e9b2057..769fdf15ded20a58372e6049da944500be6de52e 100644

--- a/pkg/analyzer_experimental/lib/src/generated/java_core.dart

+++ b/pkg/analyzer_experimental/lib/src/generated/java_core.dart

@@ -31,13 +31,10 @@ bool isInstanceOf(o, Type t) {

if (oTypeName == tTypeName) {

return true;

}

- if (oTypeName.startsWith("HashMap") && tTypeName == "Map") {

- return true;

- }

- if (oTypeName.startsWith("LinkedHashMap") && tTypeName == "Map") {

+ if (oTypeName.startsWith("List") && tTypeName == "List") {

return true;

}

- if (oTypeName.startsWith("List") && tTypeName == "List") {

+ if (tTypeName == "Map" && o is Map) {

return true;

}

// Dart Analysis Engine specific

« no previous file with comments | « editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart ('k') | pkg/mdv/lib/src/template_iterator.dart » ('j') | no next file with comments »