Make LinkedHashMap also have a factory constructor and be customizable

sdk/lib/collection/linked_hash_map.dart

Index: sdk/lib/collection/linked_hash_map.dart
diff --git a/sdk/lib/collection/linked_hash_map.dart b/sdk/lib/collection/linked_hash_map.dart
index ff6f045fa10404f0234fa17437bee3a69d5b2afe..970e48dd95ebe2591e155ffb4ac9414483723100 100644
--- a/sdk/lib/collection/linked_hash_map.dart
+++ b/sdk/lib/collection/linked_hash_map.dart
@@ -18,8 +18,9 @@ part of dart.collection;
  *
  * The map allows `null` as a key.
  */
-class LinkedHashMap<K, V> implements HashMap<K, V> {
-  external LinkedHashMap();
+abstract class LinkedHashMap<K, V> implements HashMap<K, V> {
+  external factory LinkedHashMap({ bool equals(K key1, K key2),

[floitsch, 2013/09/05 13:44:28]

If we require key1 and key2 to be of type K we might violate our requirements
(allowing lookup of super class).
Please add test, that we don't run into that problem.
Ditto for hashCode.
Alternatively we need to have an is-check in the lookup-functions.

[Lasse Reichstein Nielsen, 2013/09/06 08:49:24]

I thought about this and decided that this was the signature to require here. It
will allow more general equalities as well, but won't require them.

That means that you *can* use an equality that only works on E, and then you
better makes sure that you don't *ever* use your map on something that is not E
(but that's the same as SplayTreeMap if your comparator doesn't handle anything
else). But then, we did have a test in the lookup there. I'm not sure we want
that.

+                                   int hashCode(K key) });
 
   /**
    * Creates a [LinkedHashMap] that contains all key value pairs of [other].
@@ -64,35 +65,4 @@ class LinkedHashMap<K, V> implements HashMap<K, V> {
     Maps._fillMapWithIterables(map, keys, values);
     return map;
   }
-
-  external bool containsKey(Object key);
-
-  external bool containsValue(Object value);
-
-  external void addAll(Map<K, V> other);
-
-  external V operator [](Object key);
-
-  external void operator []=(K key, V value);
-
-  external V putIfAbsent(K key, V ifAbsent());
-
-  external V remove(Object key);
-
-  external void clear();
-
-  external void forEach(void action (K key, V value));
-
-  /** The keys of the map, in insertion order. */
-  external Iterable<K> get keys;
-  /** The values of the map, in the order of their corresponding [keys].*/
-  external Iterable<V> get values;
-
-  external int get length;
-
-  external bool get isEmpty;
-
-  external bool get isNotEmpty;
-
-  String toString() => Maps.mapToString(this);
 }