Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 23494024: [Files.app] Pass the access token to the widget by the 'initialize' message (Closed)

Created:
7 years, 3 months ago by yoshiki
Modified:
7 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Files.app] Pass the access token to the widget by the 'initialize' message CWS widget team requested to pass the access token by the 'initialize' message. BUG=none TEST=manual R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221646

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/browser/resources/file_manager/js/cws_container_client.js View 4 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/js/suggest_apps_dialog.js View 1 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
yoshiki
@hirono. could you take a look? Thanks.
7 years, 3 months ago (2013-09-06 07:04:50 UTC) #1
hirono
On 2013/09/06 07:04:50, yoshiki wrote: > @hirono. could you take a look? Thanks. lgtm!
7 years, 3 months ago (2013-09-06 07:09:50 UTC) #2
yoshiki
Committed patchset #2 manually as r221646 (presubmit successful).
7 years, 3 months ago (2013-09-06 08:29:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/23494024/4001
7 years, 3 months ago (2013-09-06 08:29:57 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 08:30:01 UTC) #5
Message was sent while issue was closed.
Failed to apply patch for
chrome/browser/resources/file_manager/js/cws_container_client.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/resources/file_manager/js/cws_container_client.js
  Hunk #1 FAILED at 12.
  Hunk #2 FAILED at 22.
  Hunk #3 FAILED at 187.
  Hunk #4 FAILED at 239.
  4 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/resources/file_manager/js/cws_container_client.js.rej

Patch:       chrome/browser/resources/file_manager/js/cws_container_client.js
Index: chrome/browser/resources/file_manager/js/cws_container_client.js
diff --git a/chrome/browser/resources/file_manager/js/cws_container_client.js
b/chrome/browser/resources/file_manager/js/cws_container_client.js
index
f380fbeb3b3d59db95b3be0a6a7b7ffeae741b49..e97709db9d4148a840e864cbc7c7549bd8f47a23
100644
--- a/chrome/browser/resources/file_manager/js/cws_container_client.js
+++ b/chrome/browser/resources/file_manager/js/cws_container_client.js
@@ -12,9 +12,11 @@
  * @param {number} height Height of the CWS widget.
  * @param {string} url Share Url for an entry.
  * @param {string} target Target (scheme + host + port) of the widget.
+ * @param {string} token Access token to access CWS.
  * @constructor
  */
-function CWSContainerClient(webView, ext, mime, width, height, url, target) {
+function CWSContainerClient(
+    webView, ext, mime, width, height, url, target, token) {
   this.webView_ = webView;
   this.ext_ = ext;
   this.mime_ = mime;
@@ -22,6 +24,7 @@ function CWSContainerClient(webView, ext, mime, width, height,
url, target) {
   this.height_ = height;
   this.url_ = url;
   this.target_ = target;
+  this.token_ = token;
 
   this.loaded_ = false;
   this.loading_ = false;
@@ -187,6 +190,7 @@ CWSContainerClient.prototype.postInitializeMessage_ =
function() {
     height: this.height_,
     file_extension: this.ext_,
     mime_type: this.mime_,
+    access_token: this.token_,
     v: 1
   };
 
@@ -239,4 +243,3 @@ CWSContainerClient.prototype.abort = function() {
 CWSContainerClient.prototype.dispose = function() {
   this.abort();
 };
-

Powered by Google App Engine
This is Rietveld 408576698