chrome/common/extensions/docs/server2/permissions_data_source.py - Issue 23494015: Docserver: fix bug where we were overriding hand-written descriptions of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/permissions_data_source.py

Issue 23494015: Docserver: fix bug where we were overriding hand-written descriptions of (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/cron.yaml ('k') | chrome/common/extensions/docs/server2/permissions_data_source_test.py » ('j') | chrome/common/extensions/docs/server2/permissions_data_source_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/permissions_data_source.py

diff --git a/chrome/common/extensions/docs/server2/permissions_data_source.py b/chrome/common/extensions/docs/server2/permissions_data_source.py

index 2a641fd0689942198ae3cb1407a0f25cf24f30a5..7662fa77ab9d91a280d622ebe0f98585ea9259ba 100644

--- a/chrome/common/extensions/docs/server2/permissions_data_source.py

+++ b/chrome/common/extensions/docs/server2/permissions_data_source.py

@@ -25,7 +25,7 @@ def _AddDependencyDescriptions(permissions, api_features):

'''

for name, permission in permissions.iteritems():

# Don't overwrite the description created by expanding a partial template.

- if 'description' in permission or not permission['platforms']:

Jeffrey Yasskin 2013/08/30 19:55:47 Do "description" keys never appear in the permissi

not at google - send to devlin 2013/08/30 20:35:33 Nope, no description. The "partial" key has a stri

+ if 'partial' in permission or not permission['platforms']:

continue

has_deps = False