Issue 23494012: Fix ppb_graphics_3d example code

Issue 23494012: Fix ppb_graphics_3d example code (Closed)

Created:
7 years, 3 months ago by abarth-chromium

Modified:
7 years, 3 months ago

Reviewers:
bbudge

CC:
chromium-reviews, piman+watch_chromium.org, raymes+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix ppb_graphics_3d example code The example code in the comments in this header file doesn't compile. This CL corrects the sample code to actually work. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220611

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address reviewer comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
	M	ppapi/api/ppb_graphics_3d.idl	View	1	2 chunks	+7 lines, -4 lines	0 comments	Download
	M	ppapi/c/ppb_graphics_3d.h	View	1	3 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

@bbudge: Please let me know if you're not the right person to review this CL. ...

7 years, 3 months ago (2013-08-30 06:25:04 UTC) #1

bbudge

LGTM Thanks for fixing this. https://codereview.chromium.org/23494012/diff/1/ppapi/api/ppb_graphics_3d.idl File ppapi/api/ppb_graphics_3d.idl (right): https://codereview.chromium.org/23494012/diff/1/ppapi/api/ppb_graphics_3d.idl#newcode98 ppapi/api/ppb_graphics_3d.idl:98: * @param[out] attrib_list specifies ...

7 years, 3 months ago (2013-08-30 12:53:00 UTC) #2

abarth-chromium

https://codereview.chromium.org/23494012/diff/1/ppapi/api/ppb_graphics_3d.idl File ppapi/api/ppb_graphics_3d.idl (right): https://codereview.chromium.org/23494012/diff/1/ppapi/api/ppb_graphics_3d.idl#newcode98 ppapi/api/ppb_graphics_3d.idl:98: * @param[out] attrib_list specifies a list of attributes for ...

7 years, 3 months ago (2013-08-30 15:37:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/23494012/7001

7 years, 3 months ago (2013-08-30 15:37:29 UTC) #4

Message was sent while issue was closed.

Change committed as 220611

Expand Messages | Collapse Messages