Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2349383004: Implement ThreadedInputConnection#getCursorCapsMode() (Closed)

Created:
4 years, 3 months ago by Changwan Ryu
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, yabinh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement ThreadedInputConnection#getCursorCapsMode() Some Latin keyboard apps use this function to check whether they need to capitalize a letter at the current cursor. Delegating to TextUtil just as BaseInputConnection#getCursorCapsMode() does. BUG=648439 Committed: https://crrev.com/0c474f4800bc19022ab2eb3521401a7462b9ecd2 Cr-Commit-Position: refs/heads/master@{#419929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java View 2 chunks +9 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 3 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Changwan Ryu
4 years, 3 months ago (2016-09-20 06:32:00 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 3 months ago (2016-09-21 01:02:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349383004/1
4 years, 3 months ago (2016-09-21 01:05:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 01:10:55 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 01:12:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c474f4800bc19022ab2eb3521401a7462b9ecd2
Cr-Commit-Position: refs/heads/master@{#419929}

Powered by Google App Engine
This is Rietveld 408576698