Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 2349383003: [Merge M54] Look into full URL spec to see whether it is MP4 (Closed)

Created:
4 years, 3 months ago by Tima Vaisburd
Modified:
4 years, 3 months ago
Reviewers:
timav
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge M54] Look into full URL spec to see whether it is MP4 On certain Android devices MediaCodec is blacklisted. To support H264 we fall back to MediaCodec, and we decide whether this is H264 by looking at URL. This CL improves that decision making: before we only checked whether the path suffisc was ".mp4", now we look for "video/mp4" in the whole URL spec as well. In addition this CL makes canPlayType() return "probably" for H264 codec. BUG=642988 TBR=timav > Review-Url: https://codereview.chromium.org/2338213005 > Cr-Commit-Position: refs/heads/master@{#419272} Committed: https://chromium.googlesource.com/chromium/src/+/f2d0438963f2df69d0ebc397a76270af8ef93052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M media/base/mime_util_internal.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Tima Vaisburd
4 years, 3 months ago (2016-09-19 23:45:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f2d0438963f2df69d0ebc397a76270af8ef93052.

Powered by Google App Engine
This is Rietveld 408576698