Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2349373002: Only close the QUIC connection after 5RTOs on the client side when the (Closed)

Created:
4 years, 3 months ago by Jana
Modified:
4 years, 3 months ago
Reviewers:
ianswett, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only close the QUIC connection after 5RTOs on the client side when the 5RTO connection option is present. Protected by ENABLED FLAGS_quic_only_5rto_client_side. For users with relatively short RTTs, the 5th RTO on the server side can occur before the client sends a PING. In networks with short NAT timeouts, this causes the connection to be abruptly closed once the NAT tunnel is re-opened by the client's PING, instead of receiving the response. Merge internal change: 133030062 R=ianswett@chromium.org, rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M net/quic/core/quic_connection.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/core/quic_connection_test.cc View 2 chunks +37 lines, -1 line 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (4 generated)
Jana
4 years, 3 months ago (2016-09-19 19:19:23 UTC) #1
Ryan Hamilton
4 years, 3 months ago (2016-09-19 19:33:16 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698